always use DEFLATE canonical form for huffman::table codes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 61.90% 61.93% +0.03%
==========================================
Files 16 16
Lines 1000 1001 +1
==========================================
+ Hits 619 620 +1
Misses 381 381 ☔ View full report in Codecov by Sentry. |
oliverlee
force-pushed
the
I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
branch
from
47e714c to
4ed4fa6
Compare
oliverlee
force-pushed
the
I50f7ea63561de0bb785c85467cdb943829b65edf
branch
2 times, most recently
from
6a09bb7 to
ec2ce26
Compare
oliverlee
force-pushed
the
I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
branch
from
4ed4fa6 to
cbb5d82
Compare
garymm
force-pushed
the
I50f7ea63561de0bb785c85467cdb943829b65edf
branch
from
ec2ce26 to
efcadda
Compare
garymm
force-pushed
the
I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
branch
from
cbb5d82 to
c6c647a
Compare
garymm
approved these changes
Oct 13, 2023
oliverlee
force-pushed
the
I50f7ea63561de0bb785c85467cdb943829b65edf
branch
from
efcadda to
811d680
Compare
garymm
force-pushed
the
I50f7ea63561de0bb785c85467cdb943829b65edf
branch
2 times, most recently
from
57ef4a6 to
ac578ee
Compare
Base automatically changed from
I50f7ea63561de0bb785c85467cdb943829b65edf
to
master
October 22, 2023 03:40
oliverlee
force-pushed
the
I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
branch
from
c6c647a to
f387aad
Compare
oliverlee
force-pushed
the
I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
branch
2 times, most recently
from
e253d92 to
200b3ef
Compare
garymm
approved these changes
Nov 21, 2023
Update huffman::table constructors to always call canonicalize(). As canonicalize() is now called in the constructor, this method is now private. Note that the table_contents constructor is an exception and does not call canonicalize(). File decode_test.cpp does not yet update the Huffman table to use canonical form as this requires the recalculating the encoded bits. Change-Id: I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
oliverlee
force-pushed
the
I5597dc51ea5e9f086c71e2f9396fccd5ace923b2
branch
from
200b3ef to
c72bc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update huffman::table constructors to always call canonicalize(). As
canonicalize() is now called in the constructor, this method is now
private.
Note that the table_contents constructor is an exception and does not
call canonicalize().
File decode_test.cpp does not yet update the Huffman table to use
canonical form as this requires the recalculating the encoded bits.
Change-Id: I5597dc51ea5e9f086c71e2f9396fccd5ace923b2